[tor-bugs] #28197 [Core Tor/sbws]: Rename some bandwidth file keys in the code

[Tor Bug Tracker & Wiki]

#28197: Rename some bandwidth file keys in the code
---------------------------+-------------------------------------
 Reporter:  juga           |          Owner:  juga
     Type:  defect         |         Status:  assigned
 Priority:  Medium         |      Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28085         |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-------------------------------------

Comment (by juga):

 Replying to [comment:3 teor]:
 [...]

 > When I worked as a database designer, we named fields using this
 pattern:
 > * optional Adjective(s) (words that modify the thing)
 > * Noun (what the thing is)
 > * optional Adjectives (words that modify the format of the data)
 > * Kind (what format the data is in)

 It's a similar pattern i was trying to follow. The main differences being:
 - in all the other humans languages i know, adjetives come after noun, so
 even if the key names are in English, my way of thinking gives more
 importance to the noum.
 - i'd have thought that units (Kind) comes at the end, except that after
 naming the keys with only nouns and units, i wanted other keys with
 adjetives to start with that noun + unit + adjetive. This was probably a
 bad choice, since i'd still put _ls for list or other "Kind"s at the end.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28197#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online