[tor-bugs] #28202 [Core Tor/Tor]: Bad end-of-string check in get_next_token (CID various)

[Tor Bug Tracker & Wiki]

#28202: Bad end-of-string check in get_next_token (CID various)
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-backport 033-backport            |  Actual Points:
  034-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


Comment:

 see branches:
    * bug28202_029 -- PR https://github.com/torproject/tor/pull/442
    * bug28202_033 -- PR https://github.com/torproject/tor/pull/443
    * bug28202_035 -- PR https://github.com/torproject/tor/pull/444

 Note that there is C pointer math here, along with ugly code and code
 movement that affected the merges.

 I'd support refactoring this code entirely in the future but for now I
 think we can't, at least not in these releases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28202#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online