[tor-bugs] #27273 [Core Tor/Tor]: ASan fails to link on Travis due to rustc and linker arguments

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Oct 25 12:46:21 UTC 2018


#27273: ASan fails to link on Travis due to rustc and linker arguments
--------------------------+------------------------------------
 Reporter:  alexcrichton  |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  High          |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:  #25386        |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Hm. One thing I found here in my own testing is that this code seems to
 fail on rust 1.29 even if the sanitizers are disabled:

 {{{
   process didn't exit successfully: `rustc - --crate-name ___ --print
 =file-names -C linker=gcc -C default-linker-libraries --target x86_64
 -unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib
 --crate-type cdylib --crate-type staticlib --crate-type proc-macro` (exit
 code: 1)
 --- stderr
 error: unknown codegen option: `default-linker-libraries`
 }}}

 I'd either like to fix this up so that it doesn't break non-hardened
 builds 1.29, or wait until 1.29 is obsolete before we merge it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27273#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list