[tor-bugs] #25885 [Core Tor/Tor]: count_acceptable_nodes() would be more accurate using node_has_preferred_descriptor()

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 23 23:26:40 UTC 2018


#25885: count_acceptable_nodes() would be more accurate using
node_has_preferred_descriptor()
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  neel
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 The changes look good to me, except that I think you mean "or" instead of
 "and" at one point. (Commented on the PR. I am not 100% sure I'm right.)

 Teor, what do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25885#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list