[tor-bugs] #26368 [Core Tor/Tor]: Consider circuit isolation when closing redundant intro points

[Tor Bug Tracker & Wiki]

#26368: Consider circuit isolation when closing redundant intro points
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, tor-client, 035-roadmap-     |  Actual Points:
  proposed, tbb-needs                            |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 I have pushed the new branch. Same PR.

 I don't believe I can write a unit test because of
 `circuit_mark_for_close()`. This function is mocked in other unit tests,
 but the mocked function is a dummy function that basically eliminates the
 functionality which needed by `rend_client_close_other_intros()` (which is
 closing circuits without isolation flags).

 A mocked function for `circuit_mark_for_close()` looks something like this
 (code snippet from `src/test`):
 {{{
 /* Mock function because we are not trying to test the close circuit that
 does
  * an awful lot of checks on the circuit object. */
 static void
 mock_circuit_mark_for_close(circuit_t *circ, int reason, int line,
                             const char *file)
 {
   (void) circ;
   (void) reason;
   (void) line;
   (void) file;
   return;
 }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26368#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online