[tor-bugs] #27741 [Core Tor/Tor]: too many arguments in rust protover_compute_vote()

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Oct 22 19:04:22 UTC 2018


#27741: too many arguments in rust protover_compute_vote()
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.6
 Severity:  Normal                               |     Resolution:
 Keywords:  035-must, protover, memory-safety,   |  Actual Points:
  033-backport, 034-backport                     |
Parent ID:  #27739                               |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cyberpunks):

 Replying to [comment:16 teor]:
 > We only applied rustfmt in 0.3.5,

 That's true. Though we might as well try to follow the rustfmt rules for
 the commits merged to maint-0.3.3 too, right? Just so that we don't need
 separate style fixups, or merge conflicts, after it's merged to 0.3.5 and
 forward.

 Also, this ticket is missing the `rust` tag.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27741#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list