[tor-bugs] #27244 [Core Tor/Tor]: Use mmap to hold our cached consensus, when we even need it stored in RAM at all.

[Tor Bug Tracker & Wiki]

#27244: Use mmap to hold our cached consensus, when we even need it stored in RAM
at all.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #27243                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by cyberpunks):

 Replying to [comment:13 ahf]:
 > Could you elaborate

 `networkstatus_set_current_consensus()` passes `s` to a few functions
 (`dirserv_set_cached_consensus_networkstatus`,
 `consdiffmgr_add_consensus`) which don't have length arguments. They still
 assume the string is null-terminated and will read past the end of the
 mmap.

 This branch doesn't have that issue.
 https://gitgud.io/onionk/tor/compare/master...consparsemmap

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27244#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online