[tor-bugs] #27471 [Core Tor/Tor]: HS intermittently fails: Non-fatal assertion failed in send_introduce1

[Tor Bug Tracker & Wiki]

#27471: HS intermittently fails: Non-fatal assertion failed in send_introduce1
-----------------------------------------------+---------------------------
 Reporter:  tgragnato                          |          Owner:  dgoulet
     Type:  defect                             |         Status:
                                               |  merge_ready
 Priority:  Very High                          |      Milestone:  Tor:
                                               |  0.3.5.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.3.4.7-rc
 Severity:  Minor                              |     Resolution:
 Keywords:  tor-hs, regression?, 035-backport  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:  asn                                |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by asan):

 It happened again on Linux 0.3.4.8:

 {{{
 Oct 18 14:10:09.000 [warn] tor_bug_occurred_(): Bug:
 ../src/or/hs_client.c:559: send_introduce1: Non-fatal assertion !(ip ==
 NULL) failed. (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug: Non-fatal assertion !(ip == NULL) failed
 in send_introduce1 at ../src/or/hs_client.c:559. Stack trace: (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(log_backtrace+0x42)
 [0x558198c723e2] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(tor_bug_occurred_+0xb7)
 [0x558198c8d1d7] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(hs_client_send_introduce1+0x232) [0x558198c4f972] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(connection_ap_handshake_attach_circuit+0x33c)
 [0x558198be0f9c] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(connection_ap_attach_pending+0x1a0) [0x558198c019d0] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(hs_client_receive_rendezvous_acked+0x79) [0x558198c500b9] (on
 Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(rend_process_relay_cell+0x28b) [0x558198b6c16b] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(+0x79097)
 [0x558198b63097] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(circuit_receive_relay_cell+0x311) [0x558198b650b1] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(command_process_cell+0x280) [0x558198be2420] (on Tor 0.3.4.8
 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(channel_tls_handle_cell+0x273) [0x558198bc4213] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(+0x11db2c)
 [0x558198c07b2c] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:
 /usr/bin/tor(connection_handle_read+0x892) [0x558198bfe542] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(+0x53a61)
 [0x558198b3da61] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x7fc) [0x7ff36f52d3dc] (on Tor
 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(do_main_loop+0x25f)
 [0x558198b3fe0f] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(tor_run_main+0x1165)
 [0x558198b422e5] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(tor_main+0x3a)
 [0x558198b3a32a] (on Tor 0.3.4.8 )
 Oct 18 14:10:09.000 [warn] Bug:     /usr/bin/tor(main+0x19)
 [0x558198b3a099] (on Tor 0.3.4.8 )
 Oct 19 12:30:09.000 [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf5) [0x7ff36deb1b45] (on Tor 0.3.4.8 )
 Oct 19 12:30:09.000 [warn] Bug:     /usr/bin/tor(+0x500e9)
 [0x558198b3a0e9] (on Tor 0.3.4.8 )
 }}}

 I hope that you will port your changes to stable releases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27471#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online