[tor-bugs] #27471 [Core Tor/Tor]: HS intermittently fails: Non-fatal assertion failed in send_introduce1

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 17 23:54:23 UTC 2018


#27471: HS intermittently fails: Non-fatal assertion failed in send_introduce1
-------------------------------------------+-------------------------------
 Reporter:  tgragnato                      |          Owner:  dgoulet
     Type:  defect                         |         Status:
                                           |  needs_revision
 Priority:  Very High                      |      Milestone:  Tor:
                                           |  0.3.5.x-final
Component:  Core Tor/Tor                   |        Version:  Tor:
                                           |  0.3.4.7-rc
 Severity:  Minor                          |     Resolution:
 Keywords:  tor-hs, regression?, 035-must  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:  asn                            |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by asn):

 Replying to [comment:15 dgoulet]:
 > Replying to [comment:14 asn]:
 > > ACK on the above.
 > >
 > > To simplify your patch, would it be possible to unify
 `circuit_get_next_client_intro_circ()` and
 `circuit_get_next_service_intro_circ()` to reduce duplicate code?
 >
 > Doable.
 >
 > >
 > > If we do that I think we can get this merged and see if this thing
 ever appears again.
 >
 > Hmmmm wait, you want the close all circuits or the lets reextend on
 error?

 Please check my branch `ticket27471_035_01` and PR:
 https://github.com/torproject/tor/pull/414

 I went with your approach of closing all open circuits, plus I added a
 fixup that unifies the two "get_intro_circ" functions into one.

 If you like it, let's squash it and put it in merge_ready. If you don't
 like it, we can put your branch into merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27471#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list