[tor-bugs] #27841 [Core Tor/Tor]: Close intro circuit after introduction has been completed

[Tor Bug Tracker & Wiki]

#27841: Close intro circuit after introduction has been completed
--------------------------+----------------------------------
 Reporter:  asn           |          Owner:  neel
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs dos    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by neel):

 Thanks for the feedback.

 I looked at `handle_introduce_ack_success()` and found this code:
 {{{
  end:
   /* We don't need the intro circuit anymore. It did what it had to do! */
   circuit_change_purpose(TO_CIRCUIT(intro_circ),
                          CIRCUIT_PURPOSE_C_INTRODUCE_ACKED);
   circuit_mark_for_close(TO_CIRCUIT(intro_circ),
 END_CIRC_REASON_FINISHED);

   /* XXX: Close pending intro circuits we might have in parallel. */
   return;
 }}}

 Isn't this already being done after the first comment above (or in
 `handle_introduce_ack_success()`)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27841#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online