[tor-bugs] #28077 [Core Tor/Tor]: remove unsafe block from cstr! macro

Wed Oct 17 00:38:01 UTC 2018

#28077: remove unsafe block from cstr! macro
--------------------------+------------------------------------
 Reporter:  cyberpunks    |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:3 cyberpunks]:
 > Replying to [comment:2 teor]:
 > > keep the interior nul byte (like the original code)
 >
 > ? There's zero behavior change in this patch.

 You're right. I misread the unsafe block.

 But I still think we don't want to hide errors by substituting the empty
 string.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28077#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online