[tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Oct 16 13:05:50 UTC 2018
#27549: hs-v3: Refactor the descriptor cookie computation code
---------------------------------+----------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, refactoring | Actual Points:
Parent ID: #27544 | Points:
Reviewer: asn | Sponsor:
---------------------------------+----------------------------------
Comment (by asn):
I pushed a fixup on my branch `ticket27549_035_01` that kills the helper
functions to simplify the patch.
The helper functions did not help with simplifying the code or with making
it more abstract since the underlying code still needed to know the
structure of keys to do:
{{{
- memcpy(client_out->client_id,
- get_client_id_from_keys(keystream), HS_DESC_CLIENT_ID_LEN);
}}}
Please review and mark as merge_ready if you like it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27549#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list