[tor-bugs] #26263 [Applications/Tor Browser]: browser app icon positioned incorrectly in macOS DMG installer window

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Oct 15 15:06:32 UTC 2018


#26263: browser app icon positioned incorrectly in macOS DMG installer window
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, tbb-8.0-issues,            |  Actual Points:
  TorBrowserTeam201810                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Kathy and I worked on this ticket last week (it seemed like an easy one to
 fix). However, so far we have failed to produce a new `.DS_Store` file
 that fixes the icon positioning problem without introducing a new problem.
 Specifically, after we create a new `.DS_Store` file which fixes the
 positioning problem, the "drag to install" background image is not shown
 at all (we also created a new background image which includes the new Tor
 Browser logo, but it makes no difference is we use the old image or the
 new one).

 We also do not know why this icon positioning problem occurs in Tor
 Browser 8 but not in 7.5.6.

 The `.DS_Store` file format is undocumented and there are not many tools
 for working with it. To create the `.DS_Store` file we tried both manual
 methods (i.e., use the Finder to set up everything correctly and then copy
 the resulting `.DS_Store` to the Tor Browser build) and an open source
 tool named `dmgbuild` that can generate `.DS_Store` files.

 Our best idea for what to do try next is to switch our DMG files to use an
 HFS+ file system inside (rather than the ISO 9660 one which we currently
 use). Mozilla made a similar switch a while ago for cross-compiled builds;
 see https://bugzilla.mozilla.org/show_bug.cgi?id=1197325#c1 for an idea of
 what is involved. Our hope is that switching to HFS+ will fix the missing
 background problem and also give us other benefits such as the ability to
 use a custom volume icon (which is shown on the macOS desktop after you
 open a DMG).

 We may need some help from boklm with the rbm changes that will be
 required, and there is also a risk that changing to HFS+ will result in
 larger DMG files.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26263#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list