[tor-bugs] #28010 [Core Tor/Tor]: shellcheck: run_trunnel.sh issues
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Oct 11 17:05:39 UTC 2018
#28010: shellcheck: run_trunnel.sh issues
------------------------------+--------------------
Reporter: rl1987 | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------+--------------------
Shellcheck (https://github.com/koalaman/shellcheck) finds the
following issues:
{{{
In run_trunnel.sh line 12:
for file in `find ./src/trunnel/ -name '*.trunnel'`; do
^-- SC2044: For loops over find output are fragile. Use find
-exec or a while read loop.
^-- SC2006: Use $(..) instead of legacy `..`.
In run_trunnel.sh line 13:
python -m trunnel ${OPTIONS} $file
^-- SC2086: Double quote to prevent
globbing and word splitting.
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28010>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list