[tor-bugs] #28008 [Core Tor/Tor]: shellcheck: coverage script issues

[Tor Bug Tracker & Wiki]

#28008: shellcheck: coverage script issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 Shellcheck (​​https://github.com/koalaman/shellcheck) finds the following
 issues:

 {{{

 In coverage line 11:
     BN=`basename $fn`
        ^-- SC2006: Use $(..) instead of legacy `..`.
                  ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 12:
     DN=`dirname $fn`
        ^-- SC2006: Use $(..) instead of legacy `..`.
                 ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 13:
     F=`echo $BN | sed -e 's/\.c$//;'`
       ^-- SC2006: Use $(..) instead of legacy `..`.
             ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 16:
     ONS=`echo ${DN}/src_*-${F}.o`
         ^-- SC2006: Use $(..) instead of legacy `..`.
               ^-- SC2086: Double quote to prevent globbing and word
 splitting.
                           ^-- SC2086: Double quote to prevent globbing and
 word splitting.


 In coverage line 23:
         GCNO=`echo $on | sed -e 's/\.o$/\.gcno/;'`
              ^-- SC2006: Use $(..) instead of legacy `..`.
                    ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 24:
         if [ -e $GCNO ]
                 ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 28:
           rm -f $GC
                 ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 29:
           gcov -o $on $fn
                   ^-- SC2086: Double quote to prevent globbing and word
 splitting.
                       ^-- SC2086: Double quote to prevent globbing and
 word splitting.


 In coverage line 30:
           if [ -e $GC ]
                   ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In coverage line 34:
               mv $GC $dst/$GC
                  ^-- SC2086: Double quote to prevent globbing and word
 splitting.
                      ^-- SC2086: Double quote to prevent globbing and word
 splitting.
                           ^-- SC2086: Double quote to prevent globbing and
 word splitting.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28008>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online