[tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

[Tor Bug Tracker & Wiki]

#28007: shellcheck: scan-build.sh issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 Shellcheck (​https://github.com/koalaman/shellcheck) finds the following
 issues:

 {{{

 In scan-build.sh line 37:
 EXTRA_CHECKERS="\
 ^-- SC2034: EXTRA_CHECKERS appears unused. Verify use (or export if used
 externally).


 In scan-build.sh line 44:
 NOISY_CHECKERS="\
 ^-- SC2034: NOISY_CHECKERS appears unused. Verify use (or export if used
 externally).


 In scan-build.sh line 56:
     $CHECKERS \
     ^-- SC2086: Double quote to prevent globbing and word splitting.


 In scan-build.sh line 65:
     $CHECKERS \
     ^-- SC2086: Double quote to prevent globbing and word splitting.


 In scan-build.sh line 70:
     $CHECKERS $OUTPUTARG \
     ^-- SC2086: Double quote to prevent globbing and word splitting.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28007>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online