[tor-bugs] #28006 [Core Tor/Tor]: shellcheck: chutney-git-bisect.sh issues

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Oct 11 16:56:41 UTC 2018


#28006: shellcheck: chutney-git-bisect.sh issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 Shellcheck (https://github.com/koalaman/shellcheck) finds the following
 issues:


 {{{

 In chutney-git-bisect.sh line 23:
     cd "$2"
     ^-- SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd
 fails.


 In chutney-git-bisect.sh line 57:
     i=$[$i+1]
       ^-- SC2007: Use $((..)) instead of deprecated $[..]


 In chutney-git-bisect.sh line 60:
 i=$[$i-1]
   ^-- SC2007: Use $((..)) instead of deprecated $[..]

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28006>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list