[tor-bugs] #27808 [Core Tor/Tor]: tor 0.3.5.early-alpha: Raw assertion failed at smartlist_core.c::191191 : idx>=0

[Tor Bug Tracker & Wiki]

#27808: tor 0.3.5.early-alpha: Raw assertion failed at smartlist_core.c::191191 :
idx>=0
---------------------------------+------------------------------------
 Reporter:  jchevali             |          Owner:  rl1987
     Type:  defect               |         Status:  needs_information
 Priority:  Very High            |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor         |        Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal               |     Resolution:
 Keywords:  regression 035-must  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by rl1987):

 Okay. I think for your usercase it should be fixed by my patch for #27928.

 The problem is the following. In `retry_listener_ports` there are two
 `smartlist_del` calls that remove `conn` (loop variable in outer loop)
 from `old_conns` smartlist. We may remove it in the inner loop (if we
 determine that rebinding may be needed (this logic wasn't exactly right -
 see #27928)) or in the outer loop (if we found exact match to one of the
 wanted ports). Or both, which happened in this case. The code may
 determine that rebinding may be needed, remove the `conn` in the inner
 loop, keep iterating the inner loop, find exact match and then try to
 remove it in outer loop, which makes tor explode.

 For now, please try applying: https://github.com/torproject/tor/pull/383

 I'll look into possibly making further changes later this week.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27808#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online