[tor-bugs] #19566 [Core Tor/Tor]: SR: Use BUG() instead of tor_assert() when we can

[Tor Bug Tracker & Wiki]

#19566: SR: Use BUG() instead of tor_assert() when we can
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tor-sr, dirauth, easy, disaster-     |  Actual Points:
  waiting-to-happen, 034-triage-20180328,        |
  034-removed-20180328 035-backport              |
Parent ID:                                       |         Points:  0.2
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Made a branch out of the patch. Added changes file. This lgtm; CI should
 pass in a jiffy.

 Branch: `ticket19566_035_01`.
 PR: https://github.com/torproject/tor/pull/554

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19566#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online