[tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

[Tor Bug Tracker & Wiki]

#28142: Merge original WTF-PAD branch
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding                                        |
Parent ID:  #28631                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:15 mikeperry]:
 > Ok I looked at the branches a bit.. One issue is that there are a fair
 amount of fixups I still need to do for Nick's remaining comments on
 PR#461.. So I'm trying to decide how to do them. For sanity/cleanliness I
 think the answer is to squash everything down in PR#547 into a fresh PR,
 and do the fixups for Nick from PR#461 on top of that branch. There is the
 question of how to handle the new commits you're adding asn, to make those
 easy for Nick to review. Some of them look like they could be squashed
 back into circuitpadding.c. The test ones can probably remain their own
 commit.
 >

 Hey Mike, good to have you back, hope the off days were good.

 I agree that the right thing to do is squash up PR#547 and start building
 from there.
 Perhaps for the extra commits that I added we can leave them as is for the
 purposes of the next  nickm review, and squash them into circuitpadding
 etc. after that review.

 For now, I keep on working on testing the remaining remove token
 functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28142#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online