[tor-bugs] #28640 [Applications/Tor Browser]: System addon does not override app-profile addon

[Tor Bug Tracker & Wiki]

#28640: System addon does not override app-profile addon
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201811,    |  Actual Points:
  TBA-a2                                         |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:8 gk]:
 > I *think* that should be all we need but `XPIProvider.jsm` code is quite
 complex. Thus, I could have missed some bit. I chose `uninstallAddon()` as
 this does a variety of things which could be useful, including deleting
 the file and I set `changed` to `true` in order to rebuild all databases
 if needed and get rid of old state. The log shows that Torbutton is taking
 from the update and no old one is initialized. It seems HTTPS-E and
 NoScript are not showing up in the menu anymore but that has happened on
 my phone before randomly. So, might just be a correlation.
 >
 > Feel free to use it if you think it's worthwhile. :)

 Thanks! I like this patch better than patching every place in XPIProvider
 where it reads the extensions on disk. I have a branch for this, but I am
 also see the Https-E and NoScript issue. The branch is `28640` in my user
 repo.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28640#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online