[tor-bugs] #28547 [Core Tor/sbws]: Monitor relays that are not measured by each sbws instance

[Tor Bug Tracker & Wiki]

#28547: Monitor relays that are not measured by each sbws instance
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128                                 |
Parent ID:  #25925                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Replying to [comment:5 teor]:
 > Replying to [comment:4 juga]:
 > > The KeyValues that depend on the scanner (not the generator), would be
 only written once a day, so we would need to look at the bandwidth files
 generated at 00:35 UTC. Any potential problem with that?.
 >
 > Why can't we report those values every hour, for the last hour?

 because if we want to report them when running generate, generate reads
 the files that the scanner produces, which are created only once a day.
 Two solutions to this:
 1. change the callback that dumps the result files to do it every hour.
    - pro: easy change
    - con: the new keyvalues we want to add need to go first to the results
 files (and create new error types for then), then read from generate
 2. generate could be other thread that happens every hour, instead of a
 different process, so that it can access to the results without the need
 to read them back from the results files.
    - pro: eliminate the need to have to run an external command, to have
 to write first the results files and then read them again
    - con: bigger change

 I'm a bit more inclinated to 2, because that would easy further
 refactorings for
 - not having all bandwidth values triplicated in v3bwfile, relaylist and
 resultdump. I can explain more about htis
 - not having to create new ResultError classes to monitor the relays

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28547#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online