[tor-bugs] #28660 [Core Tor/Tor]: rend_cache_decrement_allocation(): Bug: Underflow in rend_cache_decrement_allocation (On Windows build)

[Tor Bug Tracker & Wiki]

#28660: rend_cache_decrement_allocation(): Bug: Underflow in
rend_cache_decrement_allocation (On Windows build)
--------------------------+------------------------
 Reporter:  rl1987        |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  windows       |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by dgoulet):

 Oh wow... this actually happens also on Linux:

 {{{
 rend_cache/clean: [forking] Nov 29 09:55:04.024 [warn]
 rend_cache_decrement_allocation(): Bug: Underflow in
 rend_cache_decrement_allocation (on Tor 0.4.0.0-alpha-dev
 2240fe63feb9a8cf)
 OK
 1 tests ok.  (0 skipped)
 }}}

 This comes from `test_rend_cache_clean()` that adds entries to the
 `rend_cache` directly by using the `strmap_set_lc()` instead of
 `rend_cache_store_v2_desc_as_client()`­ which does call the increment to
 the allocation counter.

 The fix here is to simply add calls to `rend_cache_increment_allocation()`
 before adding an entry.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28660#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online