[tor-bugs] #27828 [Applications/Tor Browser]: "Check for Tor Browser update" doesn't seem to do anything

[Tor Bug Tracker & Wiki]

#27828: "Check for Tor Browser update" doesn't seem to do anything
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  TorBrowserTeam201811R                          |
Parent ID:  #25694                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * keywords:  tbb-8.0-issues, tbb-regression => tbb-8.0-issues, tbb-
     regression, TorBrowserTeam201811R
 * status:  new => needs_review


Comment:

 Here is a fix for review:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug27828-01&id=a79c1cdea0e1e73cae8ebafc27b3423828fa1816

 Changes to the Firefox code between ESR 52 and 60 caused the update
 "wizard" window to not be opened if the update had already been downloaded
 (updater state == pending), but Torbutton relies on the old behavior. Our
 patch works around the problem, although in the long run I expect Mozilla
 to remove the XUL-based update window entirely (as well as the
 `app.update.doorhanger` pref). For reference, here is the Torbutton code
 that calls the `showUpdateDownloaded()` function:
 https://gitweb.torproject.org/torbutton.git/tree/src/chrome/content/torbutton.js?h=maint-2.0#n595

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27828#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online