[tor-bugs] #28643 [Internal Services/Service - github tpo]: New github team for manual and support

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Nov 28 11:52:21 UTC 2018


#28643: New github team for manual and support
----------------------------------------------------+----------------------
 Reporter:  teor                                    |          Owner:  hiro
     Type:  task                                    |         Status:  new
 Priority:  Medium                                  |      Milestone:
Component:  Internal Services/Service - github tpo  |        Version:
 Severity:  Normal                                  |     Resolution:
 Keywords:                                          |  Actual Points:
Parent ID:                                          |         Points:
 Reviewer:                                          |        Sponsor:
----------------------------------------------------+----------------------

Comment (by teor):

 Replying to [comment:1 hiro]:
 > emmapeel should be able to push to torgit and then the git hooks we have
 should push to github and automagically close the pull request.

 Auto-closing only works when the pushed commits match the pull request.

 > We give read access to github/torproject teams so that when a PR is
 opened people can receive an email on that repository (because they are in
 the team). Then I only give write access to the pusher, which is only an
 account we use to sync between torgit and github.

 The network team has write access to some repositories, because we need it
 to close pull requests, and rebuild CI on Travis and Appveyor.

 A few people have admin access, because we need it to modify the Travis
 and Appveyor CI configs.

 > I am going to check why this PR isn't being closed automatically.
 Sometimes github is slow in syncing PR, the only important thing is that
 once something is merged the commits can be seen on github.

 The commits from github.com were squashed before pushing to
 torproject.org. So GitHub didn't close the pull request, because the
 commits did not match.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28643#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list