[tor-bugs] #28600 [Core Tor/sbws]: Refactor: store the minimum of the bandwidth values from the consenus in the results

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 26 03:21:24 UTC 2018


#28600: Refactor: store the minimum of the bandwidth values from the consenus in
the results
---------------------------+------------------------
 Reporter:  juga           |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #25925         |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by teor):

 Replying to [ticket:28600 juga]:
 > Currently we store the descriptor and network status bandwidth values in
 the raw results to be able to calculate the minimum from them in the
 bandwidth file.
 > In case we don't need to these values for anything else, we could
 calculate and store the minimum of them in the bandwidth raw results.

 The bug #28588 happened because torflow did a calculation and stored one
 value.
 We can avoid future bugs like #28588 by taking the minimum as late as
 possible.

 I think we should not do this refactor.
 What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28600#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list