[tor-bugs] #26690 [Applications/Tor Browser]: TBA: Port padlock states for .onion services to mobile

[Tor Bug Tracker & Wiki]

#26690: TBA: Port padlock states for .onion services to mobile
-------------------------------------------------+-------------------------
 Reporter:  igt0                                 |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:  #5709                                |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, TBA-a2, TorBrowserTeam201811R => tbb-mobile,
     TBA-a2, TorBrowserTeam201811
 * cc: antonela (added)


Comment:

 Sorry for the delay here. Just some nits I found:

 1) indentation (in security_mode_icon_nm.xml)
 {{{
 +        android:drawable="@drawable/ic_onion_disabled"
 +       android:maxLevel="9"/>
 }}}

 2) In the commit message

 s/Onion icons/onion icons
 s/of the Onion services hosted/of onion services hosted/

 antonela: I felt the onion icon (not the one for extended validation nor
 the one showing insecure content) was too big. Compared to the desktop,
 where the icon stays the same size-wise compared to the lock icon, the
 onion icon seems to get bigger on mobile. Could we fix that or do you want
 to leave it as-is?

 Oh, and, yes, having the things scheduled for #27657 already done here for
 mobile is pretty cool!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26690#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online