[tor-bugs] #28588 [Core Tor/sbws]: SBWS 'bw_torflow_scale' does not appear to honor relayMaxAdvertisedBandwidth

[Tor Bug Tracker & Wiki]

#28588: SBWS 'bw_torflow_scale' does not appear to honor
relayMaxAdvertisedBandwidth
-------------------------------+-------------------------------
 Reporter:  starlight          |          Owner:  (none)
     Type:  defect             |         Status:  new
 Priority:  Medium             |      Component:  Core Tor/sbws
  Version:  sbws: unspecified  |       Severity:  Normal
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-------------------------------
 Examining the current 1.0.2 branch it does not seem bw_torflow_scale()
 honors MaxAdvertisedBandwidth.  I'm having trouble following the path the
 data element follows through the (not simple) code.  Is clearly visible
 with comments in bw_sbws_scale() expressed as `min(l.desc_bw_avg, l.bw *
 scale_constant / m)` where `desc_bw_avg` is the max advertised value but
 cannot determine this value is consumed by bw_torflow_scale() or anywhere
 else.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28588>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online