[tor-bugs] #24661 [Core Tor/Tor]: accept a reasonably live consensus for guard selection

[Tor Bug Tracker & Wiki]

#24661: accept a reasonably live consensus for guard selection
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  bootstrap, clock-skew,               |  Actual Points:
  s8-bootstrap, s8-errors, ux, 035-backport-     |
  maybe, 034-backport-maybe-not, 033-backport-   |
  maybe-not, 033-triage-20180320, 034-roadmap-   |
  proposed, 034-triage-20180328,                 |
  034-included-20180328, 034-deferred-20180602,  |
  035-removed-20180711                           |
Parent ID:  #23605                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     bootstrap, clock-skew, s8-bootstrap, s8-errors, ux,
     033-triage-20180320, 034-roadmap-proposed, 034-triage-20180328,
     034-included-20180328, 034-deferred-20180602, 035-removed-20180711
     =>
     bootstrap, clock-skew, s8-bootstrap, s8-errors, ux, 035-backport-
     maybe, 034-backport-maybe-not, 033-backport-maybe-not,
     033-triage-20180320, 034-roadmap-proposed, 034-triage-20180328,
     034-included-20180328, 034-deferred-20180602, 035-removed-20180711
 * status:  needs_revision => needs_review


Comment:

 This code had non-trivial merge conflicts when cherry-picked to 0.3.3 or
 0.3.4, so I just made an 0.3.5 branch.

 See my pull request:
 https://github.com/torproject/tor/pull/536

 I am still testing it with clock skew.
 I'd like to be able to reproduce clock skew tests, maybe I can work out
 how to do that with chutney.

 The stem test will fail due to #28571.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24661#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online