[tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

[Tor Bug Tracker & Wiki]

#28142: Merge original WTF-PAD branch
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding                                        |
Parent ID:                                       |         Points:
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------

Comment (by riastradh):

 I attached a patch to address all the -Wfloat-equal and -Wfloat-conversion
 warnings.

 I didn't address -Wbad-function-casts; if you really want to appease the
 warning at the expense of code clarity, you can just take each case of

 {{{
 integer-type y = (integer-type)floor(f(x));
 }}}

 by the clumsier

 {{{
 double yd = floor(f(x));
 integer-type y = (integer-type)yd;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28142#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online