[tor-bugs] #28562 [Core Tor/Tor]: test: test_rebind.py doesn't use a temporary a DataDirectory

[Tor Bug Tracker & Wiki]

#28562: test: test_rebind.py doesn't use a temporary a DataDirectory
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-test
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Riastradh on IRC reported this with `test_rebind.sh`:

 {{{
 Tor logged: "Nov 21 20:08:11.296 [warn] Error creating directory
 /home/riastradh/.tor:
 }}}

 That test is not using a temporary dir (example: mktemp -d) so tor is
 using the default one which is `~/.tor`.

 Really not good, out tests should not poke $HOME whatsoever unless we
 change it. Solution would be to create a temp dir, spawn Tor pointing it
 to that path and then remove it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28562>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online