[tor-bugs] #28205 [Obfuscation/Snowflake]: linking against other libwebrtc binaries errors out on missing symbols

[Tor Bug Tracker & Wiki]

#28205: linking against other libwebrtc binaries errors out on missing symbols
-----------------------------------+---------------------------
 Reporter:  eighthave              |          Owner:  eighthave
     Type:  defect                 |         Status:  accepted
 Priority:  Medium                 |      Milestone:
Component:  Obfuscation/Snowflake  |        Version:
 Severity:  Major                  |     Resolution:
 Keywords:  android                |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+---------------------------

Comment (by arlolra):

 Replying to [comment:32 dcf]:
 > So I guess this means we need changes to go-webrtc to remove such
 incompatible type signatures from the public interface?
 >
 > https://github.com/golang/go/issues/24882#issuecomment-427263354 says
 "Solved my issue by writing a custom facade library which then provided an
 API which did not produce gomobile bind errors..." rather than changing
 go-webrtc, it may be possible to make a wrapper layer that provides a
 gomobile-compatible interface on the outside and speaks to go-webrtc using
 `<-chan struct{}` on the inside.

 We probably need to refactor `client/` into something like,

 {{{
 client/lib/
 client/cli/
 client/mobile/
 }}}

 where both `cli/` and `mobile/` import functionality from `lib/` but
 `cli/` has a `package main` and builds an executable, and `mobile/`
 exposes a compatible api for that need.

 We can probably do away with a `cli/` and leave that code at the top level
 of `client/` for backwards compatibility, I'm just suggesting that for
 clarity.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28205#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online