[tor-bugs] #28446 [Core Tor/sbws]: Change sbws scaling method to torflow

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Nov 20 00:07:24 UTC 2018


#28446: Change sbws scaling method to torflow
---------------------------+-------------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  needs_revision
 Priority:  Medium         |      Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:  teor           |        Sponsor:
---------------------------+-------------------------------------
Changes (by teor):

 * status:  new => needs_revision
 * reviewer:   => teor


Comment:

 Replying to [comment:4 juga]:
 > Note for irc #tor-bots humans, trac-sbws cced people and myself: Yes, Ci
 failed, i need to review it. Please don't consider this as something to
 review while i don't notify i've checked and/or fixed Ci.

 CI fails because the unit tests assume that sbws scaling is the default.
 If you don't want people to review a ticket, use the needs_revision
 status.

 I tried to review this ticket, but there is no pull request, so I didn't
 know where to put my comments.

 Here is my review:
 * If you remove an option, anyone who uses the option will get an error.
 So you should either:
   * accept the option, but ignore it, or
   * increment the sbws version to 2.0

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28446#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list