[tor-bugs] #22343 [Applications/Tor Browser]: Save as... in the context menu results in using the catch-all circuit

[Tor Bug Tracker & Wiki]

#22343: Save as... in the context menu results in using the catch-all circuit
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-linkability, tbb-usability,      |  Actual Points:
  ff52-esr, tbb-7.0-must, tbb-7.0-issues, tbb-   |
  regression, tbb-7.0-frequent,                  |
  TorBrowserTeam201811R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * keywords:
     tbb-linkability, tbb-usability, ff52-esr, tbb-7.0-must,
     tbb-7.0-issues, tbb-regression, tbb-7.0-frequent, TorBrowserTeam201811
     =>
     tbb-linkability, tbb-usability, ff52-esr, tbb-7.0-must,
     tbb-7.0-issues, tbb-regression, tbb-7.0-frequent,
     TorBrowserTeam201811R


Comment:

 Here's my manual test for confirming that the `openLinkIn()` function
 works:

 First, I set `extensions.torbutton.loglevel` to 3. Then, I navigated to
 https://torpat.ch. Next, I entered the following code in the browser
 console:

 {{{
 params = {
   fromChrome: true,
   allowThirdPartyFixup: true,
   originPrincipal: gBrowser.selectedBrowser.contentPrincipal,
   isContentWindowPrivate: true
 }

 openLinkIn("https://torpat.ch", "save", params);
 }}}
 A "File Save" dialog opened. I chose a location to save the file, and then
 in the browser console I saw the following result:

 {{{
 undefined
 [11-15 21:09:26] Torbutton INFO: tor SOCKS: https://arthuredelstein.net/
 via
                        torpat.ch:a6ba48c98fcb2812f029759c19313d35
 }}}
 So it appears the function is working and correctly uses the principal
 passed to it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22343#comment:66>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online