[tor-bugs] #28429 [Core Tor/Tor]: Make the new "extra dormant" code configurable

[Tor Bug Tracker & Wiki]

#28429: Make the new "extra dormant" code configurable
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #28335        |         Points:  .5
 Reviewer:  dgoulet       |        Sponsor:  Sponsor8
--------------------------+------------------------------------
Changes (by dgoulet):

 * cc: dgoulet (removed)
 * reviewer:   => dgoulet
 * status:  assigned => needs_revision


Comment:

 * We should put in the minimum in the man page:

 {{{
 +  if (options->DormantClientTimeout < 10*60 &&
 !options->TestingTorNetwork) {
 +    REJECT("DormantClientTimeout is too low. It must be at least 10
 minutes.");
 }}}

 * Shouldn't be 24 hours?

 {{{
 +  V(DormantClientTimeout,         INTERVAL, "12 hours"),
 }}}

 * There is a whole set of new things in that commit that shouldn't be
 there at all. Seems to be getting out of the dormant state when a client
 port connection opens? (`connection_edge.c`). Maybe do an extra commit (or
 fixup) for this explaining why this is needed in addition to the activity
 once we accept() a connection also?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28429#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online