[tor-bugs] #28466 [Applications/rbm]: rbm does not correctly apply git submodule URL changes

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 15 17:13:16 UTC 2018


#28466: rbm does not correctly apply git submodule URL changes
----------------------------------+---------------------
     Reporter:  boklm             |      Owner:  boklm
         Type:  defect            |     Status:  new
     Priority:  Medium            |  Milestone:
    Component:  Applications/rbm  |    Version:
     Severity:  Normal            |   Keywords:  tbb-rbm
Actual Points:                    |  Parent ID:
       Points:                    |   Reviewer:
      Sponsor:                    |
----------------------------------+---------------------
 rbm has an option to include git submodules when creating source tarballs
 for a build.

 rbm is initializing and updating the submodules with `git submodule update
 --init`. However looking at the git-submodule manpage, it seems that the
 `--init` submodule option will only initialize submodules which have not
 been initialized yet. If a commit is changing a submodule URL, then this
 change will not be taken into account if the submodule has been
 initialized before.

 To fix this, rbm should also run `git submodule sync`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28466>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list