[tor-bugs] #28096 [Core Tor/Tor]: Windows 8.1 and 10 relays claim to be Windows 8

[Tor Bug Tracker & Wiki]

#28096: Windows 8.1 and 10 relays claim to be Windows 8
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.2.34
 Severity:  Normal                               |     Resolution:
 Keywords:  windows, fast-fix, 029-backport,     |  Actual Points:  1.0
  033-backport, 034-backport, 035-backport       |
Parent ID:                                       |         Points:  0.2
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:  0.2 => 1.0


Comment:

 I squashed these branches:

 bug28096-029-squashed, which merges into maint-0.2.9 to maint-0.3.4.
 ​https://github.com/torproject/tor/pull/510

 bug28096-035-squashed, which merges into maint-0.3.5 and master.
 ​https://github.com/torproject/tor/pull/511

 I squashed the #28096 parts, and added code to this branch:

 ticket28308-035, which merges into maint-0.3.5:
 https://github.com/torproject/tor/pull/514

 ticket28308-master, which merges into master:
 https://github.com/torproject/tor/pull/515


 The Windows CI will fail due to #28399, so I made a working branch with
 the #28399 patch:
 https://ci.appveyor.com/project/teor2345/tor/builds/20321178

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28096#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online