[tor-bugs] #28399 [Core Tor/Tor]: Build is broken on Appveyor CI

[Tor Bug Tracker & Wiki]

#28399: Build is broken on Appveyor CI
------------------------------------------------+--------------------------
 Reporter:  rl1987                              |          Owner:  (none)
     Type:  defect                              |         Status:  new
 Priority:  Very High                           |      Milestone:  Tor:
                                                |  0.3.5.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-ci appveyor windows regression  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------

Comment (by teor):

 > I wonder if 1b57bbba02de14a52e161295270052ab7f5bee47 is at issue?

 I tried reverting it, and it still gives the same error:
 https://ci.appveyor.com/project/teor2345/tor/builds/20314300

 The config.log is in a zip file on the artifacts tab.

 When configure tests for TLS_method, it says:
 {{{
 configure:10062: checking for TLS_method
 configure:10062: i686-w64-mingw32-gcc -o conftest.exe -g -O2 -I/c/OpenSSL-
 Win32/include  -L/c/OpenSSL-Win32/lib  conftest.c -lssl -lcrypto  >&5
 configure:10062: $? = 0
 configure:10062: result: yes
 }}}

 But make says:
 {{{
 i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I..  -I../src -I../src/ext
 -I../src/ext/trunnel -I../src/trunnel -I../src/ext -Isrc/ext
 -DSHARE_DATADIR="\"/mingw32/share\"" -DLOCALSTATEDIR="\"/mingw32/var\""
 -DBINDIR="\"/mingw32/bin\"" -I/c/OpenSSL-Win32/include
 -IC:/msys64/mingw32/include   -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
 -fstack-protector-all -Wstack-protector --param ssp-buffer-size=1
 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Waddress -Warray-
 bounds -Wdate-time -Wdouble-promotion -Wduplicate-decl-specifier
 -Wduplicated-cond -Wextra -Wfloat-conversion -Wignored-attributes
 -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-field-
 initializers -Wmissing-format-attribute -Wmissing-noreturn
 -Wnormalized=nfkc -Wnull-dereference -Woverlength-strings -Woverride-init
 -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-
 value -Wshift-overflow=2 -Wsizeof-array-argument -Wstrict-overflow=1
 -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wswitch-bool
 -Wsync-nand -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-
 variable -Wunused-const-variable=2 -Wunused-local-typedefs -Wvariadic-
 macros -W -Wfloat-equal -Wundef -Wpointer-arith -Wstrict-prototypes
 -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wchar-subscripts
 -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs -Wbad-function-cast
 -Wswitch-enum -Waggregate-return -Wpacked -Wunused -Wunused-parameter
 -Wold-style-definition -Wmissing-declarations -Werror -MT src/lib/tls
 /libtor_tls_a-tortls_openssl.o -MD -MP -MF src/lib/tls/.deps/libtor_tls_a-
 tortls_openssl.Tpo -c -o src/lib/tls/libtor_tls_a-tortls_openssl.o `test
 -f 'src/lib/tls/tortls_openssl.c' || echo
 '../'`src/lib/tls/tortls_openssl.c
 ...
 bash.exe : ../src/lib/tls/tortls_openssl.c: In function
 'tor_tls_context_new':
 At line:2 char:5
 +     & $commandPath $args 2>&1
 +     ~~~~~~~~~~~~~~~~~~~~~~~~~
     + CategoryInfo          : NotSpecified:
 (../src/lib/tls/...s_context_new'::String) [], RemoteException
     + FullyQualifiedErrorId : NativeCommandError

 ../src/lib/tls/tortls_openssl.c:545:35: error: implicit declaration of
 function 'TLS_method'; did you mean 'DTLS_method'? [-Werror=implicit-
 function-declaration]
    if (!(result->ctx = SSL_CTX_new(TLS_method())))
                                    ^~~~~~~~~~
                                    DTLS_method
 ../src/lib/tls/tortls_openssl.c:545:35: error: nested extern declaration
 of 'TLS_method' [-Werror=nested-externs]
 }}}

 I am working on some fixes in my bug28399 branch.

 So far I have discovered:
 * we don't need to install the un-prefixed packages, they are for MSYS2
 (like CYGWIN)
 * we aren't installing the mingw-prefixed openssl
 * we aren't finding zstd, maybe the mingw-prefixed pkgconfig will help

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28399#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online