[tor-bugs] #28449 [Core Tor/Tor]: Do we really need to run retry_listeners_callback so often?

[Tor Bug Tracker & Wiki]

#28449: Do we really need to run retry_listeners_callback so often?
--------------------------+----------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by dgoulet):

 Function comment says:

 {{{
  * Periodic callback: Every 60 seconds, we relaunch listeners if any died.
 */
 }}}

 I'm not sure how a listener can die?... but let say the `ORPort 443` does
 die for some obscure reasons (which I would assume something close() it),
 then even retrying to listen on 443 will fail because tor will in most
 cases have changed UID (setuid()).

 Listeners can change within our torrc options (or control port) but we do
 retry them all explicitly.

 Thus, I have _no_ clue why tor would retry to listen regularly... Is it
 something that Windows could do as in kill listener fd for weird
 reasons...?

 I think that if such a thing would be possible, we should catch it in the
 poll() and then recover from there, not a callback that arbitrarily
 retries.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28449#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online