[tor-bugs] #28410 [Core Tor/Tor]: systemd restart loop when tor at default.service::Type=notify

[Tor Bug Tracker & Wiki]

#28410: systemd restart loop when tor at default.service::Type=notify
--------------------------+------------------------------------
 Reporter:  jchevali      |          Owner:  (none)
     Type:  defect        |         Status:  reopened
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.5.4-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  systemd       |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by jchevali):

 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 It appears that simply adding libsystemd-dev (amd64 215-17+deb8u7) to my
 system is enough to prevent me from building, even ''before'' I may add
 --enable-systemd to the configure command.

 {{{
 ./configure --prefix= --enable-lzma=yes --enable-zstd=no --disable-
 asciidoc --disable-unittests
 }}}

 Building with the library installed makes it error. Removing it makes it
 stop erroring.

 {{{
   ...
   ...
   ...
   CC       src/feature/hibernate/hibernate.o
 src/feature/hibernate/hibernate.c: In function ‘hibernate_begin’:
 src/feature/hibernate/hibernate.c:876:5:
    warning: implicit declaration of function ‘sd_notifyf’ [-Wimplicit-
 function-declaration]
      sd_notifyf(0, "EXTEND_TIMEOUT_USEC=%" PRIu64,
      ^
 src/feature/hibernate/hibernate.c:876:5:
   warning: nested extern declaration of ‘sd_notifyf’ [-Wnested-externs]
 src/feature/hibernate/hibernate.c:877:62:
   error: ‘TOR_USEC_PER_SEC’ undeclared (first use in this function)
      ((uint64_t)(options->ShutdownWaitLength) + 30) * TOR_USEC_PER_SEC);
                                                       ^
 src/feature/hibernate/hibernate.c:877:62:
   note: each undeclared identifier is reported only once for each function
 it appears in
 Makefile:9071: recipe for target 'src/feature/hibernate/hibernate.o'
 failed
 make[1]: *** [src/feature/hibernate/hibernate.o] Error 1
 make[1]: Leaving directory '/tmp/tor-0.3.5.4-alpha-with-lzma'
 Makefile:4987: recipe for target 'all' failed
 make: *** [all] Error 2
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28410#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online