[tor-bugs] #28399 [Core Tor/Tor]: Build is broken on Appveyor CI

[Tor Bug Tracker & Wiki]

#28399: Build is broken on Appveyor CI
--------------------------+------------------------------------------------
     Reporter:  rl1987    |      Owner:  (none)
         Type:  defect    |     Status:  new
     Priority:  Medium    |  Milestone:
    Component:  Core      |    Version:
  Tor/Tor                 |
     Severity:  Normal    |   Keywords:  tor-ci appveyor windows regression
Actual Points:            |  Parent ID:
       Points:            |   Reviewer:
      Sponsor:            |
--------------------------+------------------------------------------------
 https://ci.appveyor.com/project/torproject/tor/builds/20213306

 {{{
 bash.exe : ../src/lib/tls/tortls_openssl.c: In function
 'tor_tls_context_new':
 At line:2 char:5
 +     & $commandPath $args 2>&1
 +     ~~~~~~~~~~~~~~~~~~~~~~~~~
     + CategoryInfo          : NotSpecified:
 (../src/lib/tls/...s_context_new'::String) [], RemoteException
     + FullyQualifiedErrorId : NativeCommandError

 ../src/lib/tls/tortls_openssl.c:545:35: error: implicit declaration of
 function 'TLS_method'; did you mean 'DTLS_method'? [-Werror=implicit-
 function-declaration]
    if (!(result->ctx = SSL_CTX_new(TLS_method())))
                                    ^~~~~~~~~~
                                    DTLS_method
 ../src/lib/tls/tortls_openssl.c:545:35: error: nested extern declaration
 of 'TLS_method' [-Werror=nested-externs]
 ../src/lib/tls/tortls_openssl.c:545:35: error: passing argument 1 of
 'SSL_CTX_new' makes pointer from integer without a cast [-Werror=int-
 conversion]
 In file included from ../src/lib/tls/tortls_openssl.c:48:0:
 C:/OpenSSL-Win32/include/openssl/ssl.h:2131:10: note: expected 'const
 SSL_METHOD * {aka const struct ssl_method_st *}' but argument is of type
 'int'
  SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth);
           ^~~~~~~~~~~
 ../src/lib/tls/tortls_openssl.c:554:3: error: implicit declaration of
 function 'SSL_CTX_set_security_level'; did you mean
 'SSL_CTX_set_verify_depth'? [-Werror=implicit-function-declaration]
    SSL_CTX_set_security_level(result->ctx, 1);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
    SSL_CTX_set_verify_depth
 ../src/lib/tls/tortls_openssl.c:554:3: error: nested extern declaration of
 'SSL_CTX_set_security_level' [-Werror=nested-externs]
 ../src/lib/tls/tortls_openssl.c: In function 'prune_v2_cipher_list':
 ../src/lib/tls/tortls_openssl.c:810:25: error: initialization makes
 pointer from integer without a cast [-Werror=int-conversion]
    const SSL_METHOD *m = TLS_method();
                          ^~~~~~~~~~
 ../src/lib/tls/tortls_openssl.c: In function
 'tor_tls_client_is_using_v2_ciphers':
 ../src/lib/tls/tortls_openssl.c:919:13: error: implicit declaration of
 function 'SSL_get_client_ciphers'; did you mean 'SSL_get_current_cipher'?
 [-Werror=implicit-function-declaration]
    ciphers = SSL_get_client_ciphers(ssl);
              ^~~~~~~~~~~~~~~~~~~~~~
              SSL_get_current_cipher
 ../src/lib/tls/tortls_openssl.c:919:13: error: nested extern declaration
 of 'SSL_get_client_ciphers' [-Werror=nested-externs]
 ../src/lib/tls/tortls_openssl.c:919:11: error: assignment makes pointer
 from integer without a cast [-Werror=int-conversion]
    ciphers = SSL_get_client_ciphers(ssl);
            ^
 ../src/lib/tls/tortls_openssl.c: In function 'tor_tls_get_tlssecrets':
 ../src/lib/tls/tortls_openssl.c:1623:36: error: implicit declaration of
 function 'SSL_get_server_random'; did you mean 'SSL_get_servername'?
 [-Werror=implicit-function-declaration]
    const size_t server_random_len = SSL_get_server_random(ssl, NULL, 0);
                                     ^~~~~~~~~~~~~~~~~~~~~
                                     SSL_get_servername
 ../src/lib/tls/tortls_openssl.c:1623:36: error: nested extern declaration
 of 'SSL_get_server_random' [-Werror=nested-externs]
 ../src/lib/tls/tortls_openssl.c:1624:36: error: implicit declaration of
 function 'SSL_get_client_random'; did you mean 'SSL_get_client_CA_list'?
 [-Werror=implicit-function-declaration]
    const size_t client_random_len = SSL_get_client_random(ssl, NULL, 0);
                                     ^~~~~~~~~~~~~~~~~~~~~
                                     SSL_get_client_CA_list
 ../src/lib/tls/tortls_openssl.c:1624:36: error: nested extern declaration
 of 'SSL_get_client_random' [-Werror=nested-externs]
 ../src/lib/tls/tortls_openssl.c:1625:33: error: implicit declaration of
 function 'SSL_SESSION_get_master_key'; did you mean
 'SSL_SESSION_get_time'? [-Werror=implicit-function-declaration]
    const size_t master_key_len = SSL_SESSION_get_master_key(session, NULL,
 0);
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                  SSL_SESSION_get_time
 ../src/lib/tls/tortls_openssl.c:1625:33: error: nested extern declaration
 of 'SSL_SESSION_get_master_key' [-Werror=nested-externs]
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28399>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online