[tor-bugs] #28260 [Applications/Tor Browser]: Tor nightly builds are broken on Linux with Rust enabled (since 10/31)

[Tor Bug Tracker & Wiki]

#28260: Tor nightly builds are broken on Linux with Rust enabled (since 10/31)
-------------------------------------------+-------------------------------
 Reporter:  gk                             |          Owner:  tbb-team
     Type:  defect                         |         Status:
                                           |  needs_revision
 Priority:  High                           |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201811  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by gk):

 Replying to [comment:5 alexcrichton]:
 > Oh dear, sorry for the breakage here! This can also be fixed locally
 with a patch that looks like this --
 https://gist.github.com/alexcrichton/108f3c3bb70d8e5d250a63f0ca986d58 --
 where the feature here which requires 1.28.0 isn't used unless 1.28.0 is
 compiled in. It means that the sanitizer tests won't work on pre-1.28.0
 compilers, but that's already true for other reasons!
 >
 > If something like that would work I don't mind sending a PR for it!

 Thanks for the patch, really appreciated! I am a bit wary to either ship
 it just in our Tor Browser build environment (as we would not test tor
 `master` anymore that way) or trying to convince the tor folks to take it
 for our sake despite their policy to essentially go with Rust stable
 releases.

 This won't be the last time that we have to figure out how to deal with
 different Rust minimum version requirements (i.e. our compiler
 requirements for all platforms and all parts of the bundle vs. those tor
 has). So far I think using two different ones for our nightly builds is
 okay-ish for us. But it might be smart to think harder to be prepared for
 future issues.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28260#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online