[tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 5 17:39:25 UTC 2018


#25013: Move TorButton code to the tor browser repository
-----------------------------------------------+---------------------------
 Reporter:  igt0                               |          Owner:  tbb-team
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  High                               |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201811R  |  Actual Points:
Parent ID:  #10760                             |         Points:
 Reviewer:  gk, sysrqb, mcs,                   |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by sysrqb):

 Related to the above locales, this allows including only one locale.
 Current we ship torbutton with localization for all locales (and tor
 browser only uses one of them). I'm not sure if we want to continue
 shipping all of them or this proposed patch is better for tor browser and
 we only select the locale of the browser.

 I can see us wanting to ship torbutton with all locales within the multi-
 lingual builds, but I don't know if we should optimize for that right now.

 Another question is whether we want this as a feature extension or as a
 system extension. Arthur made a good argument for a feature extension
 allowing easily copying a new torbutton*.xpi into the tor-browser dir,
 compared with a system extension that's bundled directly into to omni jar.
 The feature extension is a little more complicated, but maybe the
 additional flexibility is worth the added complexity.

 This may already be known, but just so its documented...when testing this
 within tor-browser, we'll need something like this (assuming torbutton is
 places under toolkit/components/:
 {{{
 diff --git a/mobile/android/installer/package-manifest.in
 b/mobile/android/installer/package-manifest.in
 index 8a2a356c151c..5415d436acdd 100644
 --- a/mobile/android/installer/package-manifest.in
 +++ b/mobile/android/installer/package-manifest.in
 @@ -426,6 +426,10 @@
  @BINPATH@/chrome/devtools at JAREXT@
  @BINPATH@/chrome/devtools.manifest

 +; Torbutton
 + at BINPATH@/chrome/torbutton at JAREXT@
 + at BINPATH@/chrome/torbutton.manifest
 +
  ; [Default Preferences]
  ; All the pref files must be part of base to prevent migration bugs
  #ifdef MOZ_GECKOVIEW_JAR
 diff --git a/toolkit/components/moz.build b/toolkit/components/moz.build
 index 2bc8b12121f2..61a145335097 100644
 --- a/toolkit/components/moz.build
 +++ b/toolkit/components/moz.build
 @@ -114,3 +114,6 @@ if CONFIG['NIGHTLY_BUILD'] and CONFIG['MOZ_BUILD_APP']
 == 'browser':

  if CONFIG['MOZ_BUILD_APP'] == 'browser':
      DIRS += ['normandy']
 +
 +if CONFIG['MOZ_BUILD_APP'] == 'browser' or CONFIG['MOZ_BUILD_APP'] ==
 'mobile/android':
 +    DIRS += ['torbutton']
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:51>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list