[tor-bugs] #27299 [Core Tor/Tor]: hsv3: Clarify timing sources around hsv3 code

[Tor Bug Tracker & Wiki]

#27299: hsv3: Clarify timing sources around hsv3 code
------------------------------------------+--------------------------------
 Reporter:  asn                           |          Owner:  (none)
     Type:  defect                        |         Status:  new
 Priority:  Medium                        |      Milestone:  Tor:
                                          |  unspecified
Component:  Core Tor/Tor                  |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  tor-hs hsv3 refactoring easy  |  Actual Points:
Parent ID:  #23605                        |         Points:
 Reviewer:                                |        Sponsor:  Sponsor8-can
------------------------------------------+--------------------------------

Comment (by asn):

 Replying to [comment:1 ffmancera]:
 > I am going to work on this patch. This seems to be huge because there is
 a lot of files using timing sources in `src/features/hs`. I am going to
 add some notes in the ticket if there is no problem.

 Agreed that this is an abstract enough task that keeping notes will be
 useful.

 > I saw that we are using `approx_time()` which is an alias of
 `time(NULL)`, but at the same time and in the same file, we are using
 both. As `approx_time.h` has different utilities for timing, we should use
 it instead of `time(NULL)`. What do you think?

 Yes, I think we should be using `approx_time()` instead of `time(NULL)`
 everywhere. I don't see a reason not to.

 One of the problems with HS timing is that lots of the time sources come
 from the main event loop where `time(NULL)` is used.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27299#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online