[tor-bugs] #28096 [Core Tor/Tor]: Windows 8.1 and 10 relays claim to be Windows 8

[Tor Bug Tracker & Wiki]

#28096: Windows 8.1 and 10 relays claim to be Windows 8
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.2.34
 Severity:  Normal                               |     Resolution:
 Keywords:  windows, fast-fix, 029-backport,     |  Actual Points:  0.2
  033-backport, 034-backport, 035-backport       |
Parent ID:                                       |         Points:  0.2
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 I added the missing Windows server versions, made the "or later" text
 automatic, and deleted some unreachable code.

 The patch is bigger than I'd like to backport, but we can't report the
 correct Windows version without it. If you'd like, I can reduce the size
 of the patch by adding the unreachable pre-Windows 2000 code back in.

 Here are the branches and pull requests:

 My bug28096-029 merges cleanly from maint-0.2.9 to maint-0.3.4.
 https://github.com/torproject/tor/pull/429

 My bug28096-035 merges cleanly from maint-0.3.5 to master.
 https://github.com/torproject/tor/pull/430

 I implemented #28308 in bug28096-ticket28308-035:
 https://github.com/torproject/tor/pull/472

 Since it just has test changes and refactoring, we can merge
 bug28096-ticket28308-035 to 0.3.5 or master.

 There's still one TODO: I don't know how to just log in the main Windows
 test process. I'm going to ask nickm how to do that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28096#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online