[tor-bugs] #28096 [Core Tor/Tor]: Windows 8.1 and 10 relays claim to be Windows 8

[Tor Bug Tracker & Wiki]

#28096: Windows 8.1 and 10 relays claim to be Windows 8
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.2.34
 Severity:  Normal                               |     Resolution:
 Keywords:  windows, fast-fix, 029-backport,     |  Actual Points:  0.2
  033-backport, 034-backport, 035-backport       |
Parent ID:                                       |         Points:  0.2
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 With this code, Appveyor is reporting "Windows 8.1 or later":
 https://ci.appveyor.com/project/teor2345/tor/builds/20035097/job/6ih2pqwfrf10mtk8#L2741

 But the actual version is "Windows Server 2012 R2":
 https://www.appveyor.com/docs/windows-images-software/#operating-system

 Also, the log message is shown every time the unit tests "fork" on
 Windows.

 Looks like I'll need to revise this patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28096#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online