[tor-bugs] #28096 [Core Tor/Tor]: Windows 8.1 and 10 relays claim to be Windows 8

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Nov 4 04:38:54 UTC 2018


#28096: Windows 8.1 and 10 relays claim to be Windows 8
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.2.34
 Severity:  Normal                               |     Resolution:
 Keywords:  windows, fast-fix, 029-backport,     |  Actual Points:  0.2
  033-backport, 034-backport, 035-backport       |
Parent ID:                                       |         Points:  0.2
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:6 asn]:
 > Patch looks good in principle:
 >
 > Two things:
 > a) Do you think we can add a unittest for this `get_uname()` function to
 test that the new table entries work and will work correctly?

 I don't think we can mock the Windows API function GetVersionEx(), so that
 makes it hard to unit test get_uname(). But we do call get_uname() as part
 of test_dir_formats().

 We also call get_uname() every time tor is launched:

 https://github.com/torproject/tor/blob/67351f672450d5f13754294405243a59ddd86de9/src/app/main/main.c#L606

 I would like to print the same string for the unit tests, I'll open a
 child ticket and update the pull request.

 > b) Should we change `Windows 8` to `Windows 8 or later` even tho the
 info remains the same? Could there be scripts that break on this?

 Any scripts that expect `Windows 8` are already broken, because Tor will
 return `Windows 8` on Windows 8, 8.1, and 10.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28096#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list