[tor-bugs] #24000 [Core Tor/Tor]: circuit_send_intermediate_onion_skin() and extend_cell_format() should check for IPv6

[Tor Bug Tracker & Wiki]

#24000: circuit_send_intermediate_onion_skin() and extend_cell_format() should
check for IPv6
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, 034-triage-20180328, merge-    |  Actual Points:
  deferred, 035-triaged-in-20180711              |
Parent ID:  #24403                               |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_information => needs_revision


Comment:

 Replying to [comment:13 dgoulet]:
 > Replying to [comment:9 teor]:
 > > I am risk-averse and don't think we should merge this until we're
 ready to actually send IPv6 link specifiers. Because I don't know if this
 patch helps with bugs where we accidentally send IPv6 extends. And we
 can't really test it.
 > >
 > > ln5 is working on a proposal for IPv6 extends, so we should be able to
 merge this in 0.3.5 or 0.3.6.
 > >
 >
 > Moving this out of `merge_ready`. Lets figure this out `^`. Maybe point
 to a ticket or sth?

 When we do IPv6 reachability checks on relays in #24403, we can merge this
 code.

 We don't really have a status for that, so I'll put it in
 "needs_revision", because we need to add more code to this branch before
 it's mergeable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24000#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online