[tor-bugs] #28303 [Core Tor/Tor]: Include sys/time.h in timers.c and time_fmt.c to fix OpenBSD build

[Tor Bug Tracker & Wiki]

#28303: Include sys/time.h in timers.c and time_fmt.c to fix OpenBSD build
---------------------+------------------------------
 Reporter:  kjak     |          Owner:  (none)
     Type:  defect   |         Status:  new
 Priority:  Medium   |      Component:  Core Tor/Tor
  Version:           |       Severity:  Normal
 Keywords:  openbsd  |  Actual Points:
Parent ID:           |         Points:
 Reviewer:           |        Sponsor:
---------------------+------------------------------
 The files `src/lib/encoding/time_fmt.c` and `src/lib/evloop/timers.c` both
 need to include `sys/time.h` for `struct timeval`.  Otherwise compilation
 fails on OpenBSD with the following errors:

 {{{
   CC       src/lib/encoding/time_fmt.o
   src/lib/encoding/time_fmt.c: In function 'format_iso_time_nospace_usec':
   src/lib/encoding/time_fmt.c:318: error: dereferencing pointer to
 incomplete type
   src/lib/encoding/time_fmt.c:319: error: dereferencing pointer to
 incomplete type
   gmake[1]: *** [Makefile:9088: src/lib/encoding/time_fmt.o] Error 1
 }}}

 and

 {{{
   CC       src/lib/evloop/timers.o
   src/lib/evloop/timers.c: In function 'tv_to_timeout':
   src/lib/evloop/timers.c:115: error: dereferencing pointer to incomplete
 type
   src/lib/evloop/timers.c:116: error: dereferencing pointer to incomplete
 type
   src/lib/evloop/timers.c: In function 'timeout_to_tv':
   src/lib/evloop/timers.c:128: error: dereferencing pointer to incomplete
 type
   src/lib/evloop/timers.c:129: error: dereferencing pointer to incomplete
 type
   src/lib/evloop/timers.c: In function 'libevent_timer_reschedule':
   src/lib/evloop/timers.c:156: error: storage size of 'd' isn't known
   src/lib/evloop/timers.c:156: warning: unused variable 'd'
   gmake[1]: *** [Makefile:9088: src/lib/evloop/timers.o] Error 1
 }}}

 This change does not appear to be necessary on FreeBSD or NetBSD.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28303>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online