[tor-bugs] #28298 [Core Tor/Tor]: Tor 0.3.3.1-alpha resumes allowing RunAsDaemon=1 with relative DataDirectory

[Tor Bug Tracker & Wiki]

#28298: Tor 0.3.3.1-alpha resumes allowing RunAsDaemon=1 with relative
DataDirectory
--------------------------+------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  regression    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by arma):

 Confirmed that
 {{{
 diff --git a/src/or/config.c b/src/or/config.c
 index 2660fbd..43cc082 100644
 --- a/src/or/config.c
 +++ b/src/or/config.c
 @@ -3184,7 +3184,8 @@ warn_about_relative_paths(or_options_t *options)
    n +=
 warn_if_option_path_is_relative("GeoIPv6File",options->GeoIPv6File);
    n += warn_if_option_path_is_relative("Log",options->DebugLogFile);
    n += warn_if_option_path_is_relative("AccelDir",options->AccelDir);
 -  n +=
 warn_if_option_path_is_relative("DataDirectory",options->DataDirectory);
 +  n += warn_if_option_path_is_relative("DataDirectory",
 +                                       options->DataDirectory_option);
    n += warn_if_option_path_is_relative("PidFile",options->PidFile);

    for (config_line_t *hs_line = options->RendConfigLines; hs_line;
 }}}
 fixes it for me.

 (Did we move any other warn_about_relative_paths() strings into a new
 foo_option variable?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28298#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online